On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Mon, Nov 15, 2021 at 1:49 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I've attached an updated patch that incorporates all comments I got so
> > far. Please review it.
> >
>
> Thanks for the updated patch.
> A few minor comments:
>
> doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
>
> (1) tab in doc updates
>
> There's a tab before "Otherwise,":
>
> + copy of the relation with <parameter>relid</parameter>.
> Otherwise,
Fixed.
>
> src/backend/utils/adt/pgstatfuncs.c
>
> (2) The function comment for "pg_stat_reset_subscription_worker_sub"
> seems a bit long and I expected it to be multi-line (did you run
> pg_indent?)
I ran pg_indent on pgstatfuncs.c but it didn't become a multi-line comment.
>
> src/include/pgstat.h
>
> (3) Remove PgStat_StatSubWorkerEntry.dbid?
>
> The "dbid" member of the new PgStat_StatSubWorkerEntry struct doesn't
> seem to be used, so I think it should be removed.
> (I could remove it and everything builds OK and tests pass).
>
Fixed.
Thank you for the comments! I've updated an updated version patch.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/