Re: BUG #14999: pg_rewind corrupts control file global/pg_control

On Mon, Mar 5, 2018 at 6:01 PM, Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Mar 05, 2018 at 05:47:06PM +0900, Masahiko Sawada wrote:
>> Since files other than relation files such as vm, fsm, WAL are
>> categorize as FILE_ACTION_COPY_CONFIG, I think the name would cause
>> misreading. For example, we can use FILE_ACTION_COPY_DATA and
>> FILE_ACTION_COPY_OTHER?
>
> I am not stopped on a given name.

Hmm, when I used pg_rewind --debug with this patch the debug message
made me confused because almost database files appears with
COPY_CONFIG. Also looking at the source code comment, it says
COPY_CONFIG is aimed to configuration files. But these file are not
configuration files actually. COPY_DATA makes sense to me, but
COPY_CONFIG doesn't.

Anyway, other than that the patch looks good to me. I'd like to wait
for the Dmitory's review comment before marking this as "Ready for
Commiter".

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center