Comment and function argument names are mismatched in bugmgr.c.
От | Masahiko Sawada |
---|---|
Тема | Comment and function argument names are mismatched in bugmgr.c. |
Дата | |
Msg-id | CAD21AoBD=Of1OzL90Xx4Q-3j=-2q7=S87cs75HfutE=eCday2w@mail.gmail.com обсуждение исходный текст |
Ответы |
Re: Comment and function argument names are mismatched in bugmgr.c.
Re: Comment and function argument names are mismatched in bugmgr.c. |
Список | pgsql-hackers |
Hi all, By commit 428b1d6b, function WritebackContextInit is added but the comment of this function seems to be incorrect. *max_coalesce variable doesn't exist at anywhere. Also, I think it should be fixed that the argument name of this function does not match function declare in buf_internal.h. Patch for that attached. bufmgr.c:L4160 /* * Initialize a writeback context, discarding potential previous state. * * *max_coalesce is a pointer to a variable containing the current maximum * number of writeback requests that will be coalesced into a bigger one. A * value <= 0 means that no writeback control will be performed. max_pending * is a pointer instead of an immediate value, so the coalesce limits can * easily changed by the GUC mechanism, and so calling code does not have to * check the current configuration. */ void WritebackContextInit(WritebackContext *context, int *max_pending) { Assert(*max_pending <= WRITEBACK_MAX_PENDING_FLUSHES); context->max_pending = max_pending; context->nr_pending = 0; } buf_internal.h:L303 /* * Internal routines: only called by bufmgr * Internal buffer management routines */ /* bufmgr.c */ extern void WritebackContextInit(WritebackContext *context, int *max_coalesce); Regards, -- Masahiko Sawada
Вложения
В списке pgsql-hackers по дате отправления: