Re: Skipping logical replication transactions on subscriber side

On Tue, Jan 18, 2022 at 12:37 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jan 18, 2022 at 8:34 AM tanghy.fnst@fujitsu.com
> <tanghy.fnst@fujitsu.com> wrote:
> >
> > On Mon, Jan 17, 2022 2:18 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> >
> > 2) The following two places are not consistent in whether "= value" is surround
> > with square brackets.
> >
> > +ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> SKIP ( <replaceable
class="parameter">skip_option</replaceable>[= <replaceable class="parameter">value</replaceable>] [, ... ] )
 
> >
> > +    <term><literal>SKIP ( <replaceable class="parameter">skip_option</replaceable> = <replaceable
class="parameter">value</replaceable>[, ... ] )</literal></term>
 
> >
> > Should we modify the first place to:
> > +ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> SKIP ( <replaceable
class="parameter">skip_option</replaceable>= <replaceable class="parameter">value</replaceable> [, ... ] )
 
> >
> > Because currently there is only one skip_option - xid, and a parameter must be
> > specified when using it.
> >
>
> Good observation. Do we really need [, ... ] as currently, we support
> only one value for XID?

I think no. In the doc, it should be:

ALTER SUBSCRIPTION name SKIP ( skip_option = value )

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/