Re: pgsql: Add infrastructure to supportEphemeralNamedRelation references.

On Sat, Apr 1, 2017 at 12:01 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> rhinoceros says you missed contrib/sepgsql.

Yeah, I saw that and have pushed an attempt to fix.

> More generally, if you hack the API of some globally-referenced function,
> you ought to grep for references to it rather than just assume your
> compiler will find them all for you.  For one thing, that approach is a
> great way to fail to update relevant comments.

That's what I normally do, and thought that I had here, but clearly
I messed up.  The log shows that even in 2014, when this was
written, those calls were there.

> (And while I'm bitching, you definitely failed to update ProcessUtility's
> header comment, which like most significant functions takes some pains
> to describe all the arguments.)

Will fix.

--
Kevin Grittner