Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

1.
@@ -243,6 +243,17 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
                Form_pg_attribute att;
                TypeCacheEntry *typentry;

+
+               Form_pg_attribute attr = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
+

I think we can use "att" instead of a new variable. They have the same value.

2.
+# The bug was that when when the REPLICA IDENTITY FULL is used with dropped

There is an extra "when".