Re: BUG #19095: Test if function exit() is used fail when linked static

On Thu, Dec 04, 2025 at 12:33:55AM +0100, Daniel Gustafsson wrote:
> Thanks for the update.  This patch builds on previous patches posted in the
> thread which makes it more complicated to review.  Can you please post a full
> squashed patch against master so we can be absolutely sure we are looking at
> the tree in the same state that you are.

Yeah, I was just playing with this patch a little bit this morning,
and reworked it as the attached, adjusting a bunch of stuff inside it.
The main complaint that I have with v4 is the fact that the new check
for pthread_exit() was not split as a patch of its own, being hidden
in the perl script introduced.

Saying that, passing the path of nm as argument to the perl script is
something that feels OK here, as does the coverage check added twice
for meson and Makefile, rather than relying on enable_coverage in an
ENV.  Feel free to comment on these points, of course.

I agree with the approach of keeping the coverage
condition local to each build system rather than relying on enable_coverage  as
an environment variable. In practice, autoconf (enable_coverage) and Meson

(b_coverage) expose their coverage settings independently, so duplicating the
check avoids any accidental cross-build inconsistencies. It also prevents the
script from having to detect build-system-specific flags internally, keeping

libpq-check.pl focused only on symbol inspection. So I think it makes sense