Re: Why don't we have a small reserved OID range for patch revisions?
От | John Naylor |
---|---|
Тема | Re: Why don't we have a small reserved OID range for patch revisions? |
Дата | |
Msg-id | CACPNZCvLqzViCSXXpSpDRdTix98YfVPQ49-y-SYf15V4oPBG-w@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Why don't we have a small reserved OID range for patch revisions? (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Why don't we have a small reserved OID range for patch revisions?
|
Список | pgsql-hackers |
On Sat, Mar 9, 2019 at 1:14 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > I took a quick look at this. I went ahead and pushed the parts that > were just code cleanup in reformat_dat_file.pl, since that seemed > pretty uncontroversial. As far as the rest of it goes: Okay, thanks. > * I'm really not terribly happy with sticking this functionality into > reformat_dat_file.pl. First, there's an issue of discoverability: > it's not obvious that a script named that way would have such an > ability. Second, it clutters the script in a way that seems to me > to hinder its usefulness as a basis for one-off hacks. So I'd really > rather have a separate script named something like "renumber_oids.pl", > even if there's a good deal of code duplication between it and > reformat_dat_file.pl. > * In my vision of what this might be good for, I think it's important > that it be possible to specify a range of input OIDs to renumber, not > just "everything above N". I agree the output range only needs a > starting OID. Now it looks like: perl renumber_oids.pl --first-mapped-oid 8000 --last-mapped-oid 8999 --first-target-oid 2000 *.dat To prevent a maintenance headache, I didn't copy any of the formatting logic over. You'll also have to run reformat_dat_files.pl afterwards to restore that. It seems to work, but I haven't tested thoroughly. -- John Naylor https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Вложения
В списке pgsql-hackers по дате отправления: