Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function

Поиск
Список
Период
Сортировка
От Kirk Wolak
Тема Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function
Дата
Msg-id CACLU5mTMoj8yx-tUFk84S1tfY-byvNVAWvVJ0MqG8Bp5B-wm_A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [BUG] pg_dump does not properly deal with BEGIN ATOMIC function  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Fri, Jun 2, 2023 at 8:16 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
or with -v:

pg_dump: warning: could not resolve dependency loop among these items:
pg_dump:   FUNCTION a_f  (ID 218 OID 40664)
pg_dump:   CONSTRAINT a_pkey  (ID 4131 OID 40663)
pg_dump:   POST-DATA BOUNDARY  (ID 4281)
pg_dump:   TABLE DATA a  (ID 4278 OID 40657)
pg_dump:   PRE-DATA BOUNDARY  (ID 4280)

...
BTW, now that I see a case the default printout here seems
completely ridiculous.  I think we need to do

    pg_log_warning("could not resolve dependency loop among these items:");
    for (i = 0; i < nLoop; i++)
    {
        char        buf[1024];

        describeDumpableObject(loop[i], buf, sizeof(buf));
-       pg_log_info("  %s", buf);
+       pg_log_warning("  %s", buf);
    }

-1
  Not that I matter, but as a "consumer" the current output tells me:
- You have a Warning...
+ Here are the supporting details (visually, very clearly)

  If I comprehend the suggestion, it will label each line with a warning.  Which implies I have 6 Warnings.
It feels "off" to do it that way, especially since the only way we get the additional details is with "-v"?

Kirk...

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kirk Wolak
Дата:
Сообщение: Re: Adding SHOW CREATE TABLE
Следующее
От: "Tristan Partin"
Дата:
Сообщение: Re: [PATCH] Missing dep on Catalog.pm in meson rules