Re: [PATCH] Add support function for containment operators

Поиск
Список
Период
Сортировка
От jian he
Тема Re: [PATCH] Add support function for containment operators
Дата
Msg-id CACJufxHO4nwfu8GRwKpbA31sDbe9inJk7p0hsxGtiChNmSp6VA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Add support function for containment operators  (Kim Johan Andersson <kimjand@kimmet.dk>)
Ответы Re: [PATCH] Add support function for containment operators  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers

fix a typo and also did a minor change.

from
+ if (lowerExpr != NULL && upperExpr != NULL)
+ return (Node *) makeBoolExpr(AND_EXPR, list_make2(lowerExpr, upperExpr), -1);
+ else if (lowerExpr != NULL)
+ return (Node *) lowerExpr;
+ else if (upperExpr != NULL)
+ return (Node *) upperExpr;

to

+ if (lowerExpr != NULL && upperExpr != NULL)
+ return (Node *) makeBoolExpr(AND_EXPR, list_make2(lowerExpr, upperExpr), -1);
+ else if (lowerExpr != NULL)
+ return (Node *) lowerExpr;
+ else if (upperExpr != NULL)
+ return (Node *) upperExpr;
+ else
+ {
+ Assert(false);
+ return NULL;
+ }

because cfbot says:

15:04:38.116] make -s -j${BUILD_JOBS} clean
[15:04:38.510] time make -s -j${BUILD_JOBS} world-bin
[15:04:43.272] rangetypes.c:2908:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
[15:04:43.272] }
[15:04:43.272] ^
[15:04:43.272] 1 error generated.

also add some commit messages, I hope it will be useful.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Clang optimiser vs preproc.c
Следующее
От: Alena Rybakina
Дата:
Сообщение: Re: [PoC] Reducing planning time when tables have many partitions