Re: SupportRequestRows support function for generate_series_timestamptz

Поиск
Список
Период
Сортировка
От jian he
Тема Re: SupportRequestRows support function for generate_series_timestamptz
Дата
Msg-id CACJufxHGoaDKt9Da0a8=HygBA7A6x6YMjzzU11G3HCQzqSpSZQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: SupportRequestRows support function for generate_series_timestamptz  (David Rowley <dgrowleyml@gmail.com>)
Ответы Re: SupportRequestRows support function for generate_series_timestamptz
Список pgsql-hackers
looks good to me.

some minor questions:
/*
* Protect against overflows in timestamp_mi.  XXX convert to
* ereturn one day?
*/
if (!TIMESTAMP_NOT_FINITE(start) && !TIMESTAMP_NOT_FINITE(finish) &&
!pg_sub_s64_overflow(finish, start, &dummy))

i don't understand the comment "XXX convert to ereturn one day?".

do we need to add unlikely for "pg_sub_s64_overflow", i saw most of
pg_sub_s64_overflow have unlikely.



В списке pgsql-hackers по дате отправления: