Re: pgAgent build warnings on Fedora 32

Hi,

pgAgent throws the warnings below while compiling it on Fedora 32, which uses GCC 10. Can you please take a look?

Thanks! Devrim

===============================
 /usr/bin/make DESTDIR=/var/lib/pgsql/rpm12/BUILDROOT/pgagent_12-4.0.0-4.f32.x86_64 install
In file included from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/pgAgent.h:36,
                 from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12:
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h: In constructor 'DBconn::DBconn(const wstring&)':
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:117:19: warning: 'DBconn::m_inUse' will be initialized after [-Wreorder]
  117 |  bool             m_inUse;
      |                   ^~~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:113:19: warning:   'DBconn* DBconn::m_next' [-Wreorder]
  113 |  DBconn          *m_next;
      |                   ^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: warning:   when initialized here [-Wreorder]
   21 | DBconn::DBconn(const std::wstring &connectString)
      | ^~~~~~
In file included from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/pgAgent.h:36,
                 from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12:
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:114:19: warning: 'DBconn::m_prev' will be initialized after [-Wreorder]
  114 |  DBconn          *m_prev;
      |                   ^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:102:19: warning:   'int DBconn::m_minorVersion' [-Wreorder]
  102 |  int              m_minorVersion,
      |                   ^~~~~~~~~~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: warning:   when initialized here [-Wreorder]
   21 | DBconn::DBconn(const std::wstring &connectString)
      | ^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp: In member function 'std::wstring DBconn::ExecuteScalar(const wstring&)':
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:333:6: warning: variable 'rows' set but not used [-Wunused-but-set-variable]
  333 |  int rows = -1;
      |      ^~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp: In member function 'int Job::Execute()':
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp:157:9: warning: unused variable 'last_n_char' [-Wunused-variable]
  157 |     int last_n_char = 7;
      |         ^~~~~~~~~~~

--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR