Re: pg_hba_lookup function to get all matching pg_hba.conf entries
| От | Shulgin, Oleksandr |
|---|---|
| Тема | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |
| Дата | |
| Msg-id | CACACo5Rt9Zc+UVPO2uK8iDjtM40BddQDQGbmR8jfLej=o9O2cg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pg_hba_lookup function to get all matching pg_hba.conf entries (Haribabu Kommi <kommi.haribabu@gmail.com>) |
| Ответы |
Re: pg_hba_lookup function to get all matching pg_hba.conf entries
|
| Список | pgsql-hackers |
On Fri, Mar 18, 2016 at 7:53 AM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:
>
> On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr
> <oleksandr.shulgin@zalando.de> wrote:
> >
> > You mean change context name and correct the comment? I didn't suggest to
> > change the function name.
>
> Changed the context name and the comment only.
Check.
> >> > Still remains an issue of representing special keywords in database and
> >> > user_name fields, but there was no consensus about that though.
> >>
> >> How about adding keyword_database and keyword_user columns to listing
> >> out the keywords. These columns will be populated only when the hba line
> >> contains any keywords.
> >
> >
> > Hm... that could work too.
>
> Here I attached patch with the added two keyword columns.
>
> On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr
> <oleksandr.shulgin@zalando.de> wrote:
> >
> > You mean change context name and correct the comment? I didn't suggest to
> > change the function name.
>
> Changed the context name and the comment only.
Check.
+} lookup_hba_line_context;
^^^^^ but why TAB here?
> >> > Still remains an issue of representing special keywords in database and
> >> > user_name fields, but there was no consensus about that though.
> >>
> >> How about adding keyword_database and keyword_user columns to listing
> >> out the keywords. These columns will be populated only when the hba line
> >> contains any keywords.
> >
> >
> > Hm... that could work too.
>
> Here I attached patch with the added two keyword columns.
+ if (!tok->quoted && strcmp(tok->string, "all") == 0)
token_is_keyword(tok, "all") ?
> During the testing with different IP comparison methods like 'samehost' or
> 'samenet', the address details are not displayed. Is there any need of
> showing the IP compare method also?
> showing the IP compare method also?
Do you mean return "samehost/samenet/all" in the yet another keyword_address out parameter or something like that?
--
Alex
В списке pgsql-hackers по дате отправления: