Re: WIN32 pg_import_system_collations
| От | Juan José Santamaría Flecha |
|---|---|
| Тема | Re: WIN32 pg_import_system_collations |
| Дата | |
| Msg-id | CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: WIN32 pg_import_system_collations (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>) |
| Ответы |
Re: WIN32 pg_import_system_collations
|
| Список | pgsql-hackers |
On Wed, Nov 9, 2022 at 12:02 AM Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote:
On Mon, Nov 7, 2022 at 4:08 PM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
This looks pretty good to me. The refactoring of the non-Windows parts
makes sense. The Windows parts look reasonable on manual inspection,
but again, I don't have access to Windows here, so someone else should
also look it over.I was going to say that at least it is getting tested on the CI, but I have found out that meson changes version(). That is fixed in this version.
Now is currently failing due to [1], so maybe we can leave this patch on hold until that's addressed.
Regards,
Juan José Santamaría Flecha
В списке pgsql-hackers по дате отправления: