Re: PG compilation error with Visual Studio 2015/2017/2019
| От | Juan José Santamaría Flecha |
|---|---|
| Тема | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Дата | |
| Msg-id | CAC+AXB2JN=cFokx+K_uNQP100viD7jpeHMSR2Sv7WG2H=TKOWQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: PG compilation error with Visual Studio 2015/2017/2019 (Ranier Vilela <ranier.vf@gmail.com>) |
| Ответы |
Re: PG compilation error with Visual Studio 2015/2017/2019
|
| Список | pgsql-hackers |
On Sun, Apr 19, 2020 at 1:58 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
Em dom., 19 de abr. de 2020 às 07:16, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> escreveu:Looks good to me, but, sorry, I think I missed a glitch in the previous review.On Sat, Apr 18, 2020 at 1:43 PM Ranier Vilela <ranier.vf@gmail.com> wrote:I have some observations about this patch, related to style, if you will allow me.Please find attached a revised version.If _create_locale fail, no need to call _free_locale(loct);.Another point is, what is the difference between pg_mbstrlen and wcslen?It would not be better to use only wcslen?
pg_mbstrlen() is for multibyte strings and wcslen() is for wide-character strings, the "pg" equivalent would be pg_wchar_strlen().
Attached have the patch with this comments.
+ } else
This line needs a break, other than that LGTM.
Regards,
Juan José Santamaría Flecha
В списке pgsql-hackers по дате отправления: