Re: Removing savepointLevel from TransactionState
| От | Gurjeet Singh |
|---|---|
| Тема | Re: Removing savepointLevel from TransactionState |
| Дата | |
| Msg-id | CABwTF4Xd56qmQGoZGpY1UfvoxKSVKjMBEA=kZE_UUpuS9paw8A@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Removing savepointLevel from TransactionState (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: Removing savepointLevel from TransactionState
|
| Список | pgsql-hackers |
On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
That's surprising for dead-code removal!
Not sure which failures you're pointing to. `make check` before and after the patch on master says 'All 126 tests passed.'
Let me know about the failures, and I'll see if I can find the root cause.
Gurjeet Singh <singh.gurjeet@gmail.com> writes:ISTM you have detected a bug, not just dead code that should be removed.
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.
> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.
Surely those tests that throw error on savepointLevel change were
meant to do something important?
That's surprising for dead-code removal!
Not sure which failures you're pointing to. `make check` before and after the patch on master says 'All 126 tests passed.'
Let me know about the failures, and I'll see if I can find the root cause.
Regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: