Re: Introduce XID age and inactive timeout based replication slot invalidation

On Wed, Feb 5, 2025 at 12:58 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Nisha,
>
> Some review comments for the patch v69-0002.
>
> ======
> .../t/044_invalidate_inactive_slots.pl
>
> 2.
> +if ($ENV{enable_injection_points} ne 'yes')
> +{
> + plan skip_all => 'Injection points not supported by this build';
> +}
>
> At first, I had no idea how to build for this test. It would be good
> to include a link to the injection build instructions in a comment
> somewhere near here.
>

I’ve added comments with build instructions in v70, but I’m not sure
if a link to the documentation is necessary. I didn’t find similar
instructions in other injection point-dependent tests. Let’s see what
others think.

--
Thanks,
Nisha