Re: Remove usage of finalizers ?
| От | Vitalii Tymchyshyn |
|---|---|
| Тема | Re: Remove usage of finalizers ? |
| Дата | |
| Msg-id | CABWW-d1c_Cz1V8N6dbdk89EOz63dvWdtmG0bvVpNZwRycX3Zog@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Remove usage of finalizers ? (Dave Cramer <pg@fastcrypt.com>) |
| Ответы |
Re: Remove usage of finalizers ?
|
| Список | pgsql-jdbc |
According to jdbc javadoc Statement.close simply releases resources without waiting for them to be closed automatically.
And good behaving libs in java look for their external resources allocated. The application may have problems. Last leak I've seen was something like this.getClass().getResourceAsStream(...) != null. But this was traceable because one could find unclosed streams in heap dump.
What is proposed here is server side leak that will be invisible while analyzing application. I can't afford using such a lib in my projects.
That's rather harsh. How do you see this as introducing a server side leak ? Statements are supposed to be closed by applications as are connections.On Tue, Oct 22, 2013 at 8:36 PM, Vitalii Tymchyshyn <vit@tym.im> wrote:As for me, introducing server-side leak would be plain wrong. If it will be done, please announce in the list, I will stop recommending using postgresql in java projects.
23 жовт. 2013 03:12, користувач "Tom Dunstan" <pgsql@tomd.cc> написав:On 21 October 2013 23:03, Dave Cramer <pg@fastcrypt.com> wrote:
> Please send patches for possible solutions. I think I would be OK with
> removing them and letting people find their Statement leaks
One option if we want to keep the existing behaviour available in some
way would be to remove the finalize method from AbstractJdbc2Statement
and create subclasses of the various concrete statement classes which
could be used when a debug flag is switched on. e.g.
DebugJdbc3Statement, DebugJdbc3PreparedStatement,
DebugJdbc3CallableStatement etc which have the finalizer present.
There would be quite a few of them though, and we'd need to have a
switch everywhere that one of those is instantiated, or introduce a
factory. It's a bit gross.
IMO tracing non-closed statement leaks is probably better done in a
connection pool or jdbc debugging library anyway, so maybe we
shouldn't bother and just remove it.
One question is this, though: how many users out there aren't closing
their statements currently and are relying, accidentally or
deliberately, on the current behaviour?
Tom
В списке pgsql-jdbc по дате отправления: