Re: Online enabling of checksums
| От | Magnus Hagander |
|---|---|
| Тема | Re: Online enabling of checksums |
| Дата | |
| Msg-id | CABUevEzoeXaxbcYmMZsNF1aqdCwovys7-ChqCuGRY5+nsQZFew@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Online enabling of checksums (Alvaro Herrera <alvherre@alvh.no-ip.org>) |
| Ответы |
Re: Online enabling of checksums
|
| Список | pgsql-hackers |
On Fri, Mar 2, 2018 at 3:17 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
Magnus Hagander wrote:
> On Wed, Feb 28, 2018 at 10:07 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com
> > I'd argue this is merely a mistake in the --help text. Firstly,
> > relfilenodes are OIDs too, so I don't think "-o" is incorrect. Secondly,
> > the SGML docs actually say:
> Yeah, that one is my fault. It used to say oid all over but I noticed and
> fixed it. Except I clearly missed the --help.
Obviously option names are completely arbitrary -- you could say
"-P relfilenode" and it'd still be 'correct', since it works as
documented. But we try to make these options mnemotechnic when we can,
and I don't see any relation between "-o" and "relfilenode", so I
suggest picking some other letter. There's a whole alphabet out there.
Either "-r" or "-f" works better for me than "-o".
I have no problem with changing it to -r. -f seems a bit wrong to me, as it might read as a file. And in the future we might want to implement the ability to take full filename (with path), in which case it would make sense to use -f for that.
В списке pgsql-hackers по дате отправления: