Re: SSH Tunneling implementation

On Fri, Jul 6, 2012 at 4:26 PM, Dave Page <dpage@pgadmin.org> wrote:
> Hi
>
> On Thu, Jul 5, 2012 at 2:07 PM, Akshay Joshi
> <akshay.joshi@enterprisedb.com> wrote:
>> Hi All
>>
>> I have implemented SSH tunneling using libssh2 library and added the logic
>> into pgAdmin3. With current implementation SSH tunnel will be created using
>> password as authentication mode. I'll work on the certificate based
>> authentication. I have attached two patch files 1) SSHTunnel.patch 2)
>> vcxproj.patch (Only for Windows).
>>
>> Below are the steps to build pgadmin
>>
>> Download libssh2 source code from http://www.libssh2.org/
>>
>> On Windows:-
>>
>> Compile libssh2 library on Windows
>>
>> "libssh2.dsw" file is available in win32 folder.
>> Specify path of the OpenSSL's include folder in
>> "Properties->C++->General->Additional Include Directories"
>> Specify path of the OpenSSL and Zlib's lib folder in
>> "Properties->Linker->General->Additional Library Directories"
>>
>> Create new environment variable LIBSSH2 and set the path of the libssh2
>> folder.
>> Compile pgAdmin3.
>>
>> On Linux:-
>>
>> To compile libssh2 run ./configure, make and make install.
>> Compile pgAdmin3.
>
> OK, a few issues when testing on Mac:

I haven't actually tested it, but I have a question based on the
review by dave :-)

> - The Certificate/Password options should align with the text boxes,
> and have a title. Eg.
>
> Authentication            (*) Password     ( ) Certificate

Is that actually certificate authentication? Is it not ssh public key
authentication?


> Otherwise, I agree with Guillaume; when complete this will be a much
> needed feature. Which I suppose is unsurprising given that I asked you
> to write it :-D

Yes, +1 for this being a very useful feature!


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/