Re: Git revision in tarballs

On Thu, Jul 15, 2021 at 4:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Magnus Hagander <magnus@hagander.net> writes:
> > Putting it in the tarball making script certainly works for me,
> > though, if that's what people prefer. And that does away with the
> > "clean" part as that one blows away the whole directory between each
> > run.
>
> Actually, we *have* to do it over there, because what that script
> does is
>
>    # Export the selected git ref
>    git archive ${i} | tar xf - -C pgsql
>
>    cd pgsql
>    ./configure
>    # some irrelevant stuff
>    make dist
>
> So there's no .git subdirectory in the directory it runs "make dist"
> in.  Now maybe it'd work anyway because of the GIT_DIR environment
> variable, but what I think is more likely is that the file would
> end up containing the current master-branch HEAD commit, whereas
> the thing we actually want to record here is ${i}.

Hah, yeah, that certainly decides it. And I was even poking around
that script as well today, just nt at the same time :)


-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/