Re: Review of VS 2010 support patches

<p><br /> On Jan 2, 2012 12:02 AM, "Andrew Dunstan" <<a
href="mailto:andrew@dunslane.net">andrew@dunslane.net</a>>wrote:<br /> ><br /> ><br /> ><br /> > On
12/31/201106:10 PM, Brar Piening wrote:<br /> >><br /> >> Brar Piening wrote:<br /> >>><br />
>>>Andrew Dunstan wrote:<br /> >>>><br /> >>>> Can you narrow down exactly what in
thatcommit broke VS 2010? Are there any compiler warnings?<br /> >>><br /> >>><br /> >>> I
wasable to nail down the problem.<br /> >><br /> >><br /> >> In the absence of reaction, to keep my
promise,I'm sending the attached Patch which restores the previous working behaviour for Visual Studio 2011.<br />
>>Note however that it also restores the previous conflicts with errno.h which aren't neccessarily a problem, but
mightbe in future.<br /> >><br /> ><br /> > Yeah, are we bothered by this?:<br /> ><br /> >   +  *
ForMicrosoft Visual Studio 2010 and above we intentionally redefine<br /> >   +  * the regular Berkeley error
constantsand set them to the WSA constants.<br /> >   +  * Note that this will break if those constants are used for
anythingelse<br /> >   +  * than Windows Sockets errors.<p>If it's exposed to libpq clients, that's perhaps a
problem.If it's just internally and possibly for server extensions I don't think it's a problem - unless it creates an
incompatibilitybetween msvc and mingw, but I don't think it should? <p>/Magnus <br />