Re: [PATCH] pg_basebackup: progress report max once per second
| От | Magnus Hagander |
|---|---|
| Тема | Re: [PATCH] pg_basebackup: progress report max once per second |
| Дата | |
| Msg-id | CABUevEyW2aYwD+oxDbuMusPOAGHwXM9Sidm+w9WiAG6hvn8qJQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] pg_basebackup: progress report max once per second (Mika Eloranta <mel@ohmu.fi>) |
| Ответы |
Re: [PATCH] pg_basebackup: progress report max once per second
Re: [PATCH] pg_basebackup: progress report max once per second |
| Список | pgsql-hackers |
On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta <mel@ohmu.fi> wrote:
On 13 Nov 2013, at 20:51, Mika Eloranta <mel@ohmu.fi> wrote:Same patch as an attachment.
> Prevent excessive progress reporting that can grow to gigabytes
> of output with large databases.
Would it not make more sense to instead store the last number printed, and only print it if the percentage has changed? AIUI with this patch we still print the same thing on top of itself if it takes >1 second to get 1% further.
(Except for verbose mode - but if you're asking for verbose mode, you are *asking* to get lots of output)
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
В списке pgsql-hackers по дате отправления: