Re: Download navigation UX
От | Magnus Hagander |
---|---|
Тема | Re: Download navigation UX |
Дата | |
Msg-id | CABUevEyLzdAQoDD_1TOW1g2Kqnm-=FzmfSzskWNVE0tPs8Bqyw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Download navigation UX ("Jonathan S. Katz" <jkatz@postgresql.org>) |
Ответы |
Re: Download navigation UX
|
Список | pgsql-www |
On Tue, Jul 7, 2020 at 5:54 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 7/7/20 11:53 AM, Dave Page wrote:
>
>
> On Tue, Jul 7, 2020 at 2:15 PM Jonathan S. Katz <jkatz@postgresql.org
> <mailto:jkatz@postgresql.org>> wrote:
>
> On 7/7/20 6:02 AM, Dave Page wrote:
> > Here's an updated patch (based on Jonathan's update) which
> combines the
> > inline handler patch and removes the inline handlers from the main
> patch.
>
> Looking good. One comment:
>
> Given there's nothing dynamic about serving the new apt.js /
> download.js, we don't need to serve those dynamically from the Django
> app. We can just plop them into "/media/js", e.g.
> "/media/js/download.js" and then this becomes:
>
> <script type="text/javascript"
> src="/media/js/download.js?{{gitrev}}"></script>
>
>
> Thanks - committed with that change.
Awesome, thanks!
I still stand by my review comment that it shouldn't be multiple JS files for such trivial things.
В списке pgsql-www по дате отправления: