Re: [PATCHES] pglister & pgarchives: add deployment tests for gitlab-ci

On Thu, Aug 17, 2023 at 11:58 AM Célestin Matte
<celestin.matte@cmatte.me> wrote:
>
> Since I have an ansible script [1] to deploy pglister and pgarchives, and to avoid pushing breaking commits into
master,I've worked on adding a full deployment test to gitlab-ci. 
>
> In this series of patches for pglister:
> 0001. adds a deployment stage for gitlab-ci
> 0002. updates the tools used in the syntax check stage
> 0003. Fixes new errors found by the updated version of pep8/pycodestyle
>
> Pgarchives patches in the following email.
>
> Example test runs:
> - pglister: https://gitlab.com/cmatte/pglister/-/jobs/4890819780
> - pgarchives: https://gitlab.com/cmatte/pgarchives/-/jobs/4890879735
>
> [1]: https://gitlab.com/cmatte/ansible-pglister.git


0001 - I'm unsure if we want to hard-code something that relies on an
external repo like that into the pipelines. But that type of check in
general can make sense. But what type of errors would you expect it to
detect?

0002 - As I mentioned on the other thread (I think), our primary
platform is still buster. We shouldn't change the toolchain to
bookworm until we are ready to do it everywhere, and we are ont yet.
The part changing it to pycodestyle I think is valid on buster as well
though?

0003 - This one has already been merged right? It was already
submitted separately?

pgarchives patches:

0001 - It seems to convert the contents of the files to python3, but
the shebang still refers python2? I assume that's just an oversight?

0002 - Same basic comment applies, but also, pgarchives is not
currently hosted at gitlab, so the gitlab-ci scripts won't do much?


//Magnus