Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py

On Wed, Jan 19, 2022 at 3:30 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> Hi,
>
> I'm reviewing the patches I sent a few months ago and this short one seems to have been left mid-discussion.
>
> > I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the
samename as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need
toadd code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :) 
>
> I guess it's OK as-is, then?

Yeah, indeed that was forgotten.

Patch now conflicted with your own patch for archives frontend
address. I adjusted it for that and applied. Thanks!


--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/