Re: pgsql: New files for MERGE
| От | Pavan Deolasee |
|---|---|
| Тема | Re: pgsql: New files for MERGE |
| Дата | |
| Msg-id | CABOikdOtYSzFfBmf2FPUPjBbq=Xj2wK9+_55e0T-hyK98D9Vfw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgsql: New files for MERGE (Simon Riggs <simon@2ndquadrant.com>) |
| Список | pgsql-hackers |
On Fri, Apr 6, 2018 at 1:51 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
Given that the executor
manifestly works and has been re-engineered according to PeterG's
requests and that many performance concerns have already been
addressed prior to commit, Pavan and I were happy with it. My proposal
to commit the patch was given 5 days ahead of time and no comments
were received by anyone, not even PeterG. There was no rush and I
personally performed extensive reviews before final commit.
I think it's quite unfair to say that Simon rushed into this. He said this on 29th March:
On Thu, Mar 29, 2018 at 3:20 PM, Simon Riggs <simon@2ndquadrant.com>
On 28 March 2018 at 12:00, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
> v27 attached, though review changes are in
> the add-on 0005 patch.
This all looks good now, thanks for making all of those changes.
I propose [v27 patch1+patch3+patch5] as the initial commit candidate
for MERGE, with other patches following later before end CF.
I propose to commit this tomorrow, 30 March, about 26 hours from now.
That will allow some time for buildfarm fixing/reversion before the
Easter weekend, then other patches to follow starting 2 April. That
then gives reasonable time to follow up on other issues that we will
no doubt discover fairly soon after commit, such as additional runs by
SQLsmith and more eyeballs.
And he finally committed the patch on 2nd April late in the night. In between, there were zero objections and no comments at all. I don't know why this is considered as rushed.
Thanks,
Pavan
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-hackers по дате отправления: