Re: Use of SizeOfIptrData - is that obsolete?
| От | Pavan Deolasee |
|---|---|
| Тема | Re: Use of SizeOfIptrData - is that obsolete? |
| Дата | |
| Msg-id | CABOikdNYZyPFZr3NFBEFRVdWfK0+Dus8yBdJbx6xC5TbzYBaiw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Use of SizeOfIptrData - is that obsolete? (Tom Lane <tgl@sss.pgh.pa.us>) |
| Список | pgsql-hackers |
On Fri, Sep 23, 2016 at 12:04 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I thought removing the comment altogether was not appropriate, because
it remains true that you want to work really hard to ensure that
sizeof(ItemPointerData) is 6. We're just giving up on pretense of support
for compilers that don't believe that
Makes sense.
. I'm half tempted to introduce a
StaticAssert about it, but refrained for the moment.
I also thought about that and it probably makes sense, at least to see how buildfarm behaves. One reason to do so is that I did not find any discussion or evidence of why SizeOfIptrData magic is no longer necessary and to see if it was an unintentional change at some point.
> While htup.h refactoring happened in 9.5, I don't see any point in back
> patching this.
Agreed. Pushed to HEAD only.
Thanks.
Thanks,
Pavan
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-hackers по дате отправления: