archive_timeout behaviour when archive_mode is off (was Re: Too frequent checkpoints ?)
От | Pavan Deolasee |
---|---|
Тема | archive_timeout behaviour when archive_mode is off (was Re: Too frequent checkpoints ?) |
Дата | |
Msg-id | CABOikdM1D1jtcO59MEvgPpM2A9tit5JPs2yDwqeUQENnMMEvxg@mail.gmail.com обсуждение исходный текст |
Ответы |
Re: archive_timeout behaviour when archive_mode is off (was Re:
Too frequent checkpoints ?)
|
Список | pgsql-hackers |
(changing subject) On Thu, Feb 14, 2013 at 11:48 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Mon, Feb 11, 2013 at 5:46 PM, Pavan Deolasee >> I also noticed that the WAL file switch >> happens after archive_timeout seconds irrespective of whether >> archive_mode is turned ON or not. This happens because we don't check >> if XLogArchivingActive() in CheckArchiveTimeout() function. It looks >> wrong to me. > > +1 to fix this. I've not heard the use case where archive_timeout needs to > be used even in not archive mode... > Ok, I will write a patch to fix this. I wonder if this is worth backpatching though. The code is like that for a long time and the fact that we haven't heard any complaints about it, may be its not worth fixing in the stable branches. But I wonder if anyone else thinks otherwise. I think we should also update the documentation to be clear that archive_timeout and archive_command are used only when archive_mode is turned on. Thanks, Pavan -- Pavan Deolasee http://www.linkedin.com/in/pavandeolasee
В списке pgsql-hackers по дате отправления: