Re: [JDBC] 42.0.0.jre7, driver logging takes 30-40% of my server's time

Поиск
Список
Период
Сортировка
От Vladimir Sitnikov
Тема Re: [JDBC] 42.0.0.jre7, driver logging takes 30-40% of my server's time
Дата
Msg-id CAB=Je-GubVV=RyUJgdwGfoc4jsNkbnJk-385Vbyo4eabPZQqfw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [JDBC] 42.0.0.jre7, driver logging takes 30-40% of myserver's time  (Daniel Migowski <dmigowski@ikoffice.de>)
Ответы Re: [JDBC] 42.0.0.jre7, driver logging takes 30-40% of my server'stime
Re: 42.0.0.jre7, driver logging takes 30-40% of my server'stime
Список pgsql-jdbc
Daniel,

Would you please share your benchmarks?
I don't se how did you arrive at 30% overhead for the logging.
My benchmarks show no overhead attributed to java.util.logging.

I did try org.postgresql.benchmark.statement.ProcessResultSet.bindExecuteFetch, JDK 1.8.0_102,
columnIndexType = INDEX, getter = BEST, ncols = 5, nrows = 100, reuseStatement = false, type = BOOL, unique = false.

The results are:

9.4.1212:
150±8 us / op, 42032 bytes allocated / op
where op is "bind, execute, and fetch resultset of 100 rows, 5 bool columns each"

42.0.0:
120±8 us / op, 18032 bytes allocated / op

Note: bools are faster in 42.0.0 thanks to Jorge's improvement  in https://github.com/pgjdbc/pgjdbc/commit/e69e4a1d5502319bc810e0e4529611ba52ea386c 

String results are exactly the same:
9.4.1212: 
140±6 us / op, 54103 bytes allocated / op

42.0.0: 
140±3 us / op, 54103 bytes allocated / op

That basically means, logging is a no-op provided it is not activated.

JFR recordings show no evidence of java.util.logging on the hot methods list.
logging.isLoggable is rather simple method (it does not walk logger hierarchy), so current logging is expected to be lightweight. 

Vladimir

В списке pgsql-jdbc по дате отправления:

Предыдущее
От: Dave Cramer
Дата:
Сообщение: Re: [JDBC] how to get JDBC driver version from command line
Следующее
От: Dave Cramer
Дата:
Сообщение: Re: [JDBC] Driver performance improvements - kudos to the maintainersand the contributors