Re: speed up verifying UTF-8
| От | Vladimir Sitnikov |
|---|---|
| Тема | Re: speed up verifying UTF-8 |
| Дата | |
| Msg-id | CAB=Je-Eqcuz2MxuA0QU-6qLDrG0bvRB+UBj7JoFekM1fxk_H_g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: speed up verifying UTF-8 (John Naylor <john.naylor@enterprisedb.com>) |
| Ответы |
Re: speed up verifying UTF-8
Re: speed up verifying UTF-8 |
| Список | pgsql-hackers |
Just wondering, do you have the code in a GitHub/Gitlab branch?
>+ utf8_advance(s, state, len);
>+>+ /*
>+ * If we saw an error during the loop, let the caller handle it. We treat
>+ * all other states as success.
>+ */
>+ if (state == ERR)
>+ return 0;
Did you mean state = utf8_advance(s, state, len); there? (reassign state variable)
>I wanted to try different strides for the DFA
Does that (and "len >= 32" condition) mean the patch does not improve validation of the shorter strings (the ones less than 32 bytes)?
It would probably be nice to cover them as well (e.g. with 4 or 8-byte strides)
Vladimir
В списке pgsql-hackers по дате отправления: