Re: Perf Benchmarking and regression.

On Fri, Jun 10, 2016 at 9:37 AM, Andres Freund <andres@anarazel.de> wrote:
> On 2016-06-10 09:34:33 +0900, Michael Paquier wrote:
>> On Fri, Jun 10, 2016 at 9:19 AM, Andres Freund <andres@anarazel.de> wrote:
>> > On 2016-06-09 14:37:31 -0700, Andres Freund wrote:
>> >> I'm writing a patch right now, planning to post it later today, commit
>> >> it tomorrow.
>> >
>> > Attached.
>>
>> -        /* see bufmgr.h: OS dependent default */
>> -        DEFAULT_BACKEND_FLUSH_AFTER, 0, WRITEBACK_MAX_PENDING_FLUSHES,
>> +        0, 0, WRITEBACK_MAX_PENDING_FLUSHES,
>> Wouldn't it be better to still use LT_BACKEND_FLUSH_AFTER here, and
>> just enforce it to 0 for all the OSes at the top of bufmgr.h?
>
> What would be the point? The only reason for DEFAULT_BACKEND_FLUSH_AFTER
> was that it differed between operating systems. Now it doesn't anymore.

Then why do you keep it defined?
-- 
Michael