Re: GinPageIs* don't actually return a boolean
От | Michael Paquier |
---|---|
Тема | Re: GinPageIs* don't actually return a boolean |
Дата | |
Msg-id | CAB7nPqTqHHicdJTwk5r3Wg=ggrJDqRor9-ByCgWEGK+9GiqqtQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: GinPageIs* don't actually return a boolean (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: GinPageIs* don't actually return a boolean
|
Список | pgsql-hackers |
On Thu, Mar 10, 2016 at 11:40 PM, Robert Haas <robertmhaas@gmail.com> wrote: > We need to decide what to do about this. I disagree with Peter: I > think that regardless of stdbool, what we've got right now is sloppy > coding - bad style if nothing else. Furthermore, I think that while C > lets you use any non-zero value to represent true, our bool type is > supposed to contain only one of those two values. Therefore, I think > we should commit the full patch, back-patch it as far as somebody has > the energy for, and move on. But regardless, this patch can't keep > sitting in the CommitFest - we either have to take it or reject it, > and soon. +1, I would suggest to move ahead, !! is not really Postgres-like anyway. -- Michael
В списке pgsql-hackers по дате отправления: