Re: Review of Refactoring code for sync node detection
| От | Michael Paquier |
|---|---|
| Тема | Re: Review of Refactoring code for sync node detection |
| Дата | |
| Msg-id | CAB7nPqTpTeQxLcHHyA5_2_goC4e=WE1RVy_ABRgyoZg36wKUsQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Review of Refactoring code for sync node detection (Simon Riggs <simon@2ndQuadrant.com>) |
| Ответы |
Re: Review of Refactoring code for sync node detection
|
| Список | pgsql-hackers |
On Tue, Nov 18, 2014 at 6:33 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
Hm. I think that we are losing ourselves in this thread. The primary goal is to remove a code duplication between syncrep.c and walsender,c that exists since 9.1. Would it be possible to focus only on that for now? That's still the topic of this CF.Can we just wait on this patch until we have the whole feature?
Well, this may take some time to even define, and even if goals are clearly defined this may take even more time to have a prototype to discuss about.
We quite often break larger patches down into smaller ones, but if
they arrive in lots of small pieces its more difficult to understand
and correct issues that are happening on the larger scale. Churning
the same piece of code multiple times is rather mind numbing.
--
Michael
В списке pgsql-hackers по дате отправления: