Re: pgsql: psql: fix \connect with URIs and conninfo strings

On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

psql: fix \connect with URIs and conninfo strings

psql was already accepting conninfo strings as the first parameter in
\connect, but the way it worked wasn't sane; some of the other
parameters would get the previous connection's values, causing it to
connect to a completely unexpected server or, more likely, not finding
any server at all because of completely wrong combinations of
parameters.

This patch has broken the build on OSX:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2015-04-02%2000%3A10%3A54

My box complains as well.

I haven't looked at that in details, but it looks that there are linking problems with -lpgcommon, as it is the first time that libpq has a dependency with it.

I am seeing as well that this is at least missing at the top of connstring.c:
#ifndef FRONTEND
#error "This file is not expected to be compiled for backend code"
#endif

And that src/tools/msvc has not been updated to have connstring.c show up in the list of frontend-only objects for libpgcommon.