Re: [PATCH 05/14] Add a new relmapper.c function RelationMapFilenodeToOid that acts as a reverse of RelationMapOidToFilenode

Hi,<br /><br />This patch looks OK.<br /><br />I got 3 comments:<br />1) Why changing the OID of
pg_class_tblspc_relfilenode_indexfrom 3171 to 3455? It does not look necessary.<br />2) You should perhaps change the
headerof RelationMapFilenodeToOid so as not mentionning it as the opposite operation of RelationMapOidToFilenode but as
anoperation that looks for the OID of a relation based on its relfilenode. Both functions are opposite but
independent.<br/> 3) Both functions are doing similar operations. Could it be possible to wrap them in the same central
function?<br/><br /><div class="gmail_quote">On Thu, Nov 15, 2012 at 10:17 AM, Andres Freund <span dir="ltr"><<a
href="mailto:andres@2ndquadrant.com"target="_blank">andres@2ndquadrant.com</a>></span> wrote:<br /><blockquote
class="gmail_quote"style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br />
 src/backend/utils/cache/relmapper.c| 53 +++++++++++++++++++++++++++++++++++++<br />  src/include/catalog/indexing.h  
  |  4 +--<br />  src/include/utils/relmapper.h       |  2 ++<br />  3 files changed, 57 insertions(+), 2
deletions(-)<br/><br /><br /><br /> --<br /> Sent via pgsql-hackers mailing list (<a
href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> To make changes to your
subscription:<br/><a href="http://www.postgresql.org/mailpref/pgsql-hackers"
target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/><br /></blockquote></div><br /><br clear="all"
/><br/>-- <br />Michael Paquier<br /><a href="http://michael.otacoo.com"
target="_blank">http://michael.otacoo.com</a><br/>