Re: [HACKERS] Small patch for pg_basebackup argument parsing

On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy <ryanfmurphy@gmail.com> wrote:
> I tried to apply your patch to test it (though reading Robert's last comment it seems we wish to have it adjusted
beforecommitting)... but in any case I was not able to apply your patch to the tip of the master branch (my git apply
failed). I'm setting this to Waiting On Author for a new patch, and I also agree with Robert that the test can be
simplerand can go in the other order.  If you don't have time to make another patch, let me know, I may be able to make
one.

git is unhappy even if forcibly applied with patch -p1. You should
check for whitespaces at the same time:
$ git diff --check
src/bin/pg_basebackup/pg_receivewal.c:483: indent with spaces.
+    char       *strtol_endptr = NULL
And there are more than this one.
--
Michael