Re: [PATCH] Remove redundant if clause in standbydesc.c
От | Michael Paquier |
---|---|
Тема | Re: [PATCH] Remove redundant if clause in standbydesc.c |
Дата | |
Msg-id | CAB7nPqREvpH6Ex5nKYdkPmkP3iVWW1UHo_1KwsP=kR69OF3=aQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Remove redundant if clause in standbydesc.c (Aleksander Alekseev <a.alekseev@postgrespro.ru>) |
Ответы |
Re: [PATCH] Remove redundant if clause in standbydesc.c
|
Список | pgsql-hackers |
On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev <a.alekseev@postgrespro.ru> wrote: >> > Very simple small patch - see attachment. >> >> /* not expected, but print something anyway */ >> else if (msg->id == SHAREDINVALRELMAP_ID) >> - appendStringInfoString(buf, " relmap"); >> - else if (msg->id == SHAREDINVALRELMAP_ID) >> appendStringInfo(buf, " relmap db %u", msg->rm.dbId); >> >> Looking at inval.c, dbId can be InvalidOid. > > Frankly I'm not very familiar with this part of code. InvalidOid is just > zero. Does it create some problem in this case? Not really but my guess is that the two conditions have been left for this purpose. -- Michael
В списке pgsql-hackers по дате отправления: