Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200)
От | Michael Paquier |
---|---|
Тема | Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200) |
Дата | |
Msg-id | CAB7nPqQeMQ8K3Vwh+T7Gq0O3i-3kiRyNPue9WRgqJQVuFAbZrQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200) (Michael Paquier <michael.paquier@gmail.com>) |
Ответы |
Re: [sqlsmith]
FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c",
Line: 10200)
|
Список | pgsql-hackers |
On Thu, Aug 4, 2016 at 4:38 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > Andreas, with the patch attached is the assertion still triggered? > > Thoughts from others are welcome as well. Self review: * of streaming base backups currently in progress. forcePageWrites is set * to true when either of theseis non-zero. lastBackupStart is the latest * checkpoint redo location used as a starting point for an online backup. + * exclusiveBackupStarted is true while pg_start_backup() is being called + * during an exclusive backup. */ bool exclusiveBackup; int nonExclusiveBackups; XLogRecPtr lastBackupStart; + bool exclusiveBackupStarted; It would be better to just use one variable that uses an enum to track the following states of an exclusive backup: none, starting and in-progress. -- Michael
В списке pgsql-hackers по дате отправления: