Re: pg_rewind and log messages

On Tue, Apr 7, 2015 at 4:33 PM, Fujii Masao wrote:
> Isn't the term "PostgreSQL superuser" confusing? I'm afraid that a user might
> confuse "PostgreSQL superuser" with a database superuser. I see you just
> borrowed that term from pg_resetxlog.c, though. BTW, initdb and pg_ctl also
> have the same check and the error message is as follows. Isn't this better?
> Thought?
>
>             ("%s: cannot be run as root\n"
>                        "Please log in (using, e.g., \"su\") as the "
>                        "(unprivileged) user that will\n"
>                        "own the server process.\n

I'm fine with that as well. Why not updating the message of
pg_resetxlog as well then? It would be good to be consistent.

I guess that the call to set_pglocale_pgservice() should be added as
well in the first patch (see last version upthread), this has nothing
to do with the logging issues.
-- 
Michael