Re: [HACKERS] Windows warnings from VS 2017

On Thu, Sep 21, 2017 at 7:49 AM, Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> On 09/20/2017 06:13 PM, Michael Paquier wrote:
>> On Thu, Sep 21, 2017 at 7:08 AM, Andrew Dunstan
>> <andrew.dunstan@2ndquadrant.com> wrote:
>>> First, it warns about a couple of unused variables at lines 4553 and
>>> 4673 of src/backend/optimizer/path/costsize.c. I think we can do a
>>> little rearrangement to keep it happy there.
>> Those are around for some time, see here:
>> https://www.postgresql.org/message-id/CAB7nPqTkW=b_1JVvYWd_G0WrKOT+4uFQjGGrv8osQbUZzXGXdA@mail.gmail.com
>> But there has been no actual agreement about how to fix them..
>
> Oh. Missed that.
>
> My solution was going to be slightly different. I was going to enclose
> the #ifdef'd code in a bare block and move the rte declaration inside
> that block.

That looks like a fine approach to me.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers