Re: [pgadmin-hackers] Autoformatting
От | Robert Eckhardt |
---|---|
Тема | Re: [pgadmin-hackers] Autoformatting |
Дата | |
Msg-id | CAAtBm9W26mkG-fhT=tGdOOpZfs=nirUxV_RKYc+TU6XwEt964A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgadmin-hackers] Autoformatting (Dave Page <dpage@pgadmin.org>) |
Ответы |
Re: [pgadmin-hackers] Autoformatting
|
Список | pgadmin-hackers |
On Tue, May 9, 2017 at 4:26 AM, Dave Page <dpage@pgadmin.org> wrote:
Anyhoo, The standard we try to use in pgAdmin at the moment is slightly different from the example you've given. To add it into the mix.../* Keywords Upper, 4 space indent, commas after, AND/OR after,* no spaces after ( or before ), or around ::*/SELECT DISTINCTdep.deptype,dep.classid,coalesce(coc.relname, clrw.relname) AS ownertableFROMpg_depend depLEFT JOIN pg_class cl ON dep.objid = cl.oidLEFT JOIN pg_attribute att ON dep.objid = att.attrelid AND dep.objsubid = att.attnumWHEREdep.objid = 16385::oid ANDclassid IN (SELECToidFROMpg_classWHERErelname IN ('pg_class', 'pg_constraint'))ORDER BYclassid,cl.relkind;There are some subtleties that are open to personal taste there;- Formatting of the sub-select - e.g. should the SELECT directly follow the (, and should the rest be indented accordingly?- Formatting of multiple quals in the joins; e.g. should the qual following the AND be on the next line, and if so, should it be indented one level, or to align with the qual above? Should the first qual be on the next line?--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Sorry I let this linger. Let's go with the style you currently have. With respect to your additional comments.
- Sub-Select should be a new line and indented as in your example.
- For multiple quals in the joins; the qual following the AND should be on the next line, and should it be indented one level
-- Rob
В списке pgadmin-hackers по дате отправления: