Re: add modulo (%) operator to pgbench
| От | David Rowley |
|---|---|
| Тема | Re: add modulo (%) operator to pgbench |
| Дата | |
| Msg-id | CAApHDvrRMadf9BTSuMXsNJbx2Psz9fHiKFPcxWKOMO5F9sOfvA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: add modulo (%) operator to pgbench (Fabien COELHO <coelho@cri.ensmp.fr>) |
| Ответы |
Re: add modulo (%) operator to pgbench
Re: add modulo (%) operator to pgbench Re: add modulo (%) operator to pgbench |
| Список | pgsql-hackers |
On 1 January 2015 at 21:23, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
I was about to go and look at this, but I had a problem when attempting to
compile with MSVC.
Thanks! Here is a v4 which includes your fix.
I'm also just looking at you ERROR() macro, it seems that core code is quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is not defined. I'd say this needs to be fixed too. Have a look at the trick used in elog.h for when HAVE__VA_ARGS is not defined.
Regards
David Rowley
В списке pgsql-hackers по дате отправления: