Re: logical changeset generation v6.8
| От | David Rowley |
|---|---|
| Тема | Re: logical changeset generation v6.8 |
| Дата | |
| Msg-id | CAApHDvqOsb4nc3OG0xoBoJ2fmA-6AkihuWsAd43RLekqk6SmCQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: logical changeset generation v6.8 (Andres Freund <andres@2ndquadrant.com>) |
| Список | pgsql-hackers |
On Sat, Dec 14, 2013 at 12:12 AM, Andres Freund <andres@2ndquadrant.com> wrote:
On 2013-12-13 20:58:24 +1300, David Rowley wrote:
> On Wed, Dec 11, 2013 at 1:11 PM, Robert Haas <robertmhaas@gmail.com> wrote:> This introduced a new compiler warning on the visual studios build:I thought we'd managed to get elog(ERROR) properly annotated as noreturn
> d:\postgres\b\src\backend\utils\cache\relcache.c(3958): warning C4715:
> 'RelationGetIndexAttrBitmap' : not all control paths return a value
> [D:\Postgres\b\postgres.vcxproj]
>
> The attached patch fixes it.
on msvc as well?
It looks like this is down to the elog macro, where the elevel is being assigned to a variable elevel_ then we're only doing pg_unreachable(); if elevel_ >= ERROR. The compiler must not be confident enough to optimise out the if condition even though the elevel is not changed after it is set from the constant.
Regards
David Rowley
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-hackers по дате отправления: