Re: v14.0 segfaults on certain memoize query plans

On Wed, 20 Oct 2021 at 02:38, Markus Zucker <mz@enospc.net> wrote:
> #0  0x0000564ab6686d83 in pg_detoast_datum (datum=0x2707cb3db0b4a) at ./build/../src/backend/utils/fmgr/fmgr.c:1724
> No locals.
> #1  0x0000564ab660744c in hash_range (fcinfo=0x7ffd30af2910) at ./build/../src/backend/utils/adt/rangetypes.c:1314
>          r = <optimized out>
>          result = <optimized out>
>          typcache = <optimized out>
>          scache = <optimized out>
>          lower = {val = 139813693468928, infinite = 88, inclusive = 55, lower = 135}
>          upper = {val = 94878908251905, infinite = 224, inclusive = 40, lower = 175}
>          empty = false
>          flags = <optimized out>
>          lower_hash = <optimized out>
>          upper_hash = <optimized out>
>          __func__ = "hash_range"
> #2  0x0000564ab6685dcd in FunctionCall1Coll (flinfo=flinfo@entry=0x564ab7ac3240, collation=<optimized out>,
> arg1=<optimized out>) at ./build/../src/backend/utils/fmgr/fmgr.c:1138
>          fcinfodata = {fcinfo = {flinfo = 0x564ab7ac3240, context = 0x0, resultinfo = 0x0, fncollation = 0, isnull =
> false, nargs = 1, args = 0x7ffd30af2930},
>            fcinfo_data = "@2\254\267JV", '\000' <repeats 24 times>,
"\001\000J\v۳|p\002\000\000\000\000\000\000\000\000"}
>          fcinfo = 0x7ffd30af2910
>          result = <optimized out>
>          __func__ = "FunctionCall1Coll"
>          __errno_location = <optimized out>
> #3  0x0000564ab6407f69 in MemoizeHash_hash (key=0x0, tb=<optimized out>, tb=<optimized out>) at

Thanks for reporting this.  It looks like this might be the same as
the problem reported in [1]. I proposed a patch in [2].

I'm not quite clear yet if it's safe to add a new field to the end of
RestrictInfo in PG14, or I'll need to just insist that the left and
right types are the same for 14.

David

[1]
https://www.postgresql.org/message-id/flat/CAHoyFK93fwrO%2BiGqBiPKs-j6-MgFkBh8jLnPzVy3BPOanyTCjw%40mail.gmail.com#f8ea881e0d00065f3c4b4ee235362d03
[2] https://www.postgresql.org/message-id/CAHoyFK93fwrO+iGqBiPKs-j6-MgFkBh8jLnPzVy3BPOanyTCjw@mail.gmail.com