Use of "long" in incremental sort code
От | David Rowley |
---|---|
Тема | Use of "long" in incremental sort code |
Дата | |
Msg-id | CAApHDvpky+Uhof8mryPf5i=6e6fib2dxHqBrhp0Qhu0NeBhLJw@mail.gmail.com обсуждение исходный текст |
Ответы |
Re: Use of "long" in incremental sort code
Re: Use of "long" in incremental sort code |
Список | pgsql-hackers |
Hi, I noticed the incremental sort code makes use of the long datatype a few times, e.g in TuplesortInstrumentation and IncrementalSortGroupInfo. (64-bit windows machines have sizeof(long) == 4). I understand that the values are in kilobytes and it would take 2TB to cause them to wrap. Never-the-less, I think it would be better to choose a better-suited type. work_mem is still limited to 2GB on 64-bit Windows machines, so perhaps there's some argument that it does not matter about fields that related to in-memory stuff, but the on-disk fields are wrong. The in-memory fields likely raise the bar further for fixing the 2GB work_mem limit on Windows. Maybe Size would be better for the in-memory fields and uint64 for the on-disk fields? David
В списке pgsql-hackers по дате отправления: