Re: missing rename support
От | Ali Dar |
---|---|
Тема | Re: missing rename support |
Дата | |
Msg-id | CAAj60S5W6Q=atye3gYtRd478R85WyRxoGd1-Zm1RuoqDPciVOw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: missing rename support (Dean Rasheed <dean.a.rasheed@gmail.com>) |
Список | pgsql-hackers |
The tweaks made by you seems fine. I'm good with it.
Regards,
Ali Dar
On Sun, Feb 3, 2013 at 8:04 PM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
On 29 January 2013 15:34, Ali Dar <ali.munir.dar@gmail.com> wrote:This looks good. I've tested it, and it appears to work as intended.
> Please find attached the complete patch for alter rename rule. I have
> followed all the suggestions.
I'm happy with the code, and the new docs and regression tests look
OK.
I have a couple of minor tweaks (see attached):
* On the new manual page, I replaced "table" with "table or view".
* In the new tab-completion code, I modified the query so that it
completes with tables as well as views, and limited the results to
just those relations that have a rule with the name specified,
otherwise the list of completions could be very long.
If you're happy with these changes, I think this is ready for committer review.
Regards,
Dean
В списке pgsql-hackers по дате отправления: