Re: Small patch to fix build on Windows

чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera <alvherre@2ndquadrant.com>:
>
> On 2019-Aug-08, Dmitry Igrishin wrote:
>
> >               my $prefixcmd =
> > -               $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
> > +               "\"$solution->{options}->{python}\\python\" -c \"$pythonprog\"";
>
> I think you can make this prettier like this:
>
>    my $prefixcmd = qq{"$solution->{options}->{python}\\python" -c "$pythonprog"};
This looks nice for a Perl hacker :-). As for me, it looks unusual and
a bit confusing. I never
programmed in Perl, but I was able to quickly understand where the
problem lies due to the
 style adopted in other languages, when the contents are enclosed in
quotation marks, and
the quotation marks are escaped if they are part of the contents.
So, should I fix it? Any thoughts?