Re: Missing import in 035_standby_logical_decoding.pl

On Mon, Aug 4, 2025 at 3:49 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Fri, Aug 01, 2025 at 03:04:20PM -0400, Melanie Plageman wrote:
>
> > but it does not import usleep as other tests do (like this)
> > use Time::HiRes qw(usleep);
> >
> > I think it simply hasn't been called because postgres exits and
> > terminates the loop before it has had a chance to be called. If you
> > reorder the sleep and the loop termination condition, it fails
> > immediately because it can't find usleep.
>
> Thanks for the report! I think it's an oversight in commit 48796a98d5ae. Fixed
> in the attached.

I've committed and backported the fix.

> > On an unrelated note, I also noticed that hot_standby_feedback is not
> > turned on during the test until we are explicitly checking for
> > recovery conflicts.
>
> Yeah, it's expected.

I see. I had to change it to be on for more of the test scenarios in
my patchset which sets the VM on-access [1] (v6-0017), but I suppose
it doesn't make sense to make this change on master.

- Melanie

[1] https://www.postgresql.org/message-id/CAAKRu_bGCgUuhmy1Mzkw3yCmbGcjNQAjV%3DOmjuW6hz90PuXKWA%40mail.gmail.com