Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
| От | Melanie Plageman |
|---|---|
| Тема | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
| Дата | |
| Msg-id | CAAKRu_Zbjj0=fAiuUZWwyLb8Wz+FhPj7N-p_CLkvSjbEeZL6Gw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode (Daniel Gustafsson <daniel@yesql.se>) |
| Ответы |
Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
|
| Список | pgsql-hackers |
On Wed, Apr 26, 2023 at 8:31 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 26 Apr 2023, at 13:26, David Rowley <dgrowleyml@gmail.com> wrote:
> On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada.mshk@gmail.com <mailto:sawada.mshk@gmail.com>> wrote:
> It works but I think we might want to add the unit kB for
> understandability and consistency with other GUC_UNIT_KB parameters.
> I've attached a small patch that adds the unit and aligns the indent
> of the comments to the perimeter parameters.
>
> I'm not currently able to check, but if work_mem has a unit in the sample conf then I agree that vacuum_buffer_usage_limit should too.
+1 work_mem and all other related options in this section has a unit in the
sample conf so adding this makes sense.
Agreed.
for the patch, the other GUCs have a tab instead of a space between the unit and the "#" of the first comment.
(not the fault of this patch but probably makes sense to fix now).
Otherwise, LGTM
- Melanie
В списке pgsql-hackers по дате отправления: